fix: Trace format with snapshots and elements for wdio examples#225
Merged
vishnuv688 merged 10 commits intoJun 11, 2026
Merged
Conversation
- Network: Remove HAR format so player.vibium.dev can parse it - Launcher: check mode/trace + disableDebugger BEFORE start() so backend never binds a port in trace mode - Service: drain snapshot captures before next command to prevent fire-and-forget page-state skew; skip monolithic JSON write in trace mode (no double I/O) - SessionCapturer: track #lastSelector from $/$$/findElement and inject it into element-scoped commands for trace readability - Zip writer: include transcript.md in trace.zip output
- Capture Date.now() in beforeCommand, thread through to CommandLog, use in trace exporter
…lication is traced
- Scenario Outline has a limitation of returning BLANK pages on last snapshot
- Removing `disableDebugger` - Introducing `#lastActionTimestamp` - Adding `--fix` flag in eslint scripts
- "Un-truncating" selectors in transcript
vishnuv688
approved these changes
Jun 11, 2026
738eba4
into
webdriverio:vv/devtools-tracemode
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How
Architecture self-check
CLAUDE.md§7 is being resolved.)service,nightwatch-devtools, orselenium-devtoolsimports from another adapter.backend/app. Neither package reaches into adapter internals.fetch(...),ws.send(...), or HTTP route has a typed request/response shape inshared(or inservicetypes ifshareddoesn't exist yet, with a TODO to move).if (framework === '...')outside an adapter. Framework branching uses a typedFrameworkId.anyat package boundaries. Internalanyis acceptable only at a documented framework-edge with a one-line comment.Multi-adapter changes
Debt scoreboard
If new debt is introduced, it must be added to
CLAUDE.md§7 in this PR.Testing
shared/core(required perCLAUDE.md§4).CLAUDE.md§4).pnpm buildpasses.pnpm testpasses.pnpm lintpasses.example/(orexamplefor the framework I changed).If any required item is skipped, say so here with the reason:
<your note, or "n/a">
Screenshots / recordings (UI changes only)